[infra] Preserve nightly artifacts across reruns#57
Merged
vikuznetsov-nvidia merged 2 commits intoJul 21, 2026
Conversation
Defer aggregation and cleanup after matrix failures so selective job reruns can reuse successful jobs' staging artifacts.
vikuznetsov-nvidia
requested review from
hrabeti-nvidia and
slepichev
as code owners
July 21, 2026 10:46
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe nightly workflow enables overwriting named artifacts and requires successful ChangesNightly artifact handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/nightly.ymlTraceback (most recent call last): Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Line 577: Update the three upload-artifact steps in the nightly workflow to
ensure reruns replace existing staging artifacts, either by enabling overwrite:
true or by incorporating the workflow attempt into each artifact name. Preserve
the existing artifact grouping and consolidation behavior.
- Line 356: Replace every actions/download-artifact and actions/upload-artifact
tag reference in the nightly workflow, including the usages near the identified
download steps, with the approved immutable commit SHA for each action version;
keep the existing action inputs and workflow behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 8c3d0678-53e0-46f1-981f-a15cd208bd1b
📒 Files selected for processing (1)
.github/workflows/nightly.yml
Overwrite fixed-name artifacts so selective retries publish current outputs instead of colliding with stale results from earlier attempts.
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer aggregation and cleanup after matrix failures so selective job reruns can reuse successful jobs' staging artifacts.
Summary by CodeRabbit